serial: T3397: Remove --keep-baud
which could result in unexpected baud rate
#4201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Prevents serial terminals from using unexpected baud rate
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
serial, console
Proposed changes
This change removes
--keep-baud
which can result in an unexpected baud rate for serial terminals.When a specific baud rate speed is defined, or it is falling back to the VyOS default value of 115200.
--keep-baud
can result in the config value not being honoured.If the terminal was created with a baud rate other than the config defined value, the config value will not be applied.
How to test
Tested on a Supermicro SOL serial port mapped to /dev/ttyS1. BIOS/IPMI is set to 115200.
stty -aF /dev/ttyS1
default output:speed 9600 baud; rows 24; columns 80; ...
After
set system console device ttyS1 speed 115200
:speed 9600 baud; rows 24; columns 80; ...
Removing
--keep-baud
:speed 115200 baud; rows 24; columns 80; ...
Smoketest result
Checklist: